Messages in this thread | | | Date | Thu, 17 Jul 2008 11:49:30 +0200 | From | "Boris Petkov" <> | Subject | Re: [PATCH] Fix collateral damage to top level Makefile |
| |
On Thu, Jul 17, 2008 at 10:50 AM, Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote: > On Thu, 2008-07-17 at 16:27 +0900, Paul Mundt wrote: >> On Thu, Jul 17, 2008 at 01:06:55AM -0600, Grant Likely wrote: >> > From: Grant Likely <grant.likely@secretlab.ca> >> > >> > The patch named "powerpc/mpc5121: Add clock driver", also contained >> > an unrelated and bogus change to the top-level makefile. This patch >> > backs out the bad bit. >> > >> > SHA1 of offending patch: 137e95906e294913fab02162e8a1948ade49acb5) >> > >> > Signed-off-by: Grant Likely <grant.likely@secretlab.ca> >> > --- >> > >> > If the maintainer who picked up this patch (Grant Likely) had done >> > his job, this cack-up never would have happened. Why do we still >> > have to deal with such sloppy individuals? >> > >> I think the more important question is why the hell would anyone put that >> in a Makefile, ever? ;-) > > Well, it's partially my fault for not spotting it when pulling in > Grant's git and pushing out to Linus. > > Anyway, it's a mistake, shit happens, I doubt Grant will do that one > twice :-)
Oh come on, don't scare the guy more than he is - now he'll be staring frantically at each +-diff line before submitting :). And it's not like it's the end of the world, it's just that Fred has turned 42 or similar :)
P.S. If I only knew how such an innocent thing would destroy a man's life i never would've reported it in the first place :). Sorry Grant.
-- Regards/Gruß, Boris -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |