Messages in this thread | | | Subject | Re: ACPI WARNING: at drivers/acpi/tables/tbfadt.c:348 acpi_tb_create_local_fadt+0x147/0x2f4() | From | Andi Kleen <> | Date | Thu, 17 Jul 2008 11:00:14 +0200 |
| |
"Andrew Paprocki" <andrew@ishiboo.com> writes:
[cc Bob More. What is your opinion?]
> This most definitely broke because of: > > commit 01a5bba576b9364b33f61f0cd9fa70c2cf5535e2 > Author: Jan Beulich <jbeulich@novell.com> > Date: Wed Jul 16 23:27:08 2008 +0200 > > Fix FADT parsing > > I added printk()s and this is what is reported here:
Thanks for the detailed analysis.
> > printk(KERN_INFO > "xpm1a_event_block bit_width=%d pm1_register_length=%d\n", > acpi_gbl_FADT.xpm1a_event_block.bit_width, pm1_register_length); > acpi_tb_init_generic_address(&acpi_gbl_xpm1a_enable, > pm1_register_length, > (acpi_gbl_FADT.xpm1a_event_block.address + > pm1_register_length)); > > [ 0.000000] xpm1a_event_block bit_width=8 pm1_register_length=0 > > The bit width is not % 16, so the following patch addition a few lines > earlier fails: > > WARN_ON(ACPI_MOD_16(acpi_gbl_FADT.xpm1a_event_block.bit_width));
I'll queue a revert for now until this can be resolved properly.
-Andi
| |