Messages in this thread | | | From | Kumar Gala <> | Subject | Re: [PATCH] powerpc/ep8248e: Fix compile problem if !CONFIG_FS_ENET | Date | Wed, 16 Jul 2008 17:01:28 -0500 |
| |
On Jul 16, 2008, at 4:47 PM, Scott Wood wrote:
> On Wed, Jul 16, 2008 at 08:39:12AM -0500, Kumar Gala wrote: >> If we don't enable FS_ENET we get build issues: >> >> arch/powerpc/platforms/built-in.o: In function `ep8248e_mdio_probe': >> arch/powerpc/platforms/82xx/ep8248e.c:129: undefined reference to >> `alloc_mdio_bitbang' >> arch/powerpc/platforms/82xx/ep8248e.c:143: undefined reference to >> `mdiobus_register' > > How is this possible? CONFIG_EP8248E selects CONFIG_MDIO_BITBANG. > >> +#ifdef CONFIG_FS_ENET_MDIO_FCC >> static void ep8248e_set_mdc(struct mdiobb_ctrl *ctrl, int level) >> { >> if (level) >> @@ -164,6 +165,7 @@ static struct of_platform_driver >> ep8248e_mdio_driver = { >> .probe = ep8248e_mdio_probe, >> .remove = ep8248e_mdio_remove, >> }; >> +#endif > > This is wrong -- ep8248e doesn't use the FS_ENET_MDIO_FCC code.
You're correct this should be CONFIG_MDIO_BITBANG
- k
| |