Messages in this thread | | | Subject | Re: BUG: unable to handle kernel NULL pointer dereference at 000000000000000e (reset_prng_context) | From | Joe Perches <> | Date | Wed, 16 Jul 2008 09:57:26 -0700 |
| |
On Wed, 2008-07-16 at 01:49 +0400, Alexey Dobriyan wrote: > On Tue, Jul 15, 2008 at 01:44:07PM -0700, David Miller wrote: > > From: Ingo Molnar <mingo@elte.hu> > > > Note that the new crypto/prng.c driver has very bad quality: > > I think we should merge new drivers as aggressively as possible. > Well, I don't have strong opinion about this exact statement, but > Ingo, COULD YOU PLEASE [...] STOP THIS > CHECKPATCH.PL-AS-INDICATOR HORSESHIT !
Coding style conformity (easy and clinical) and quality (hard and emotional) are only weakly correlated in software.
I think that Ingo sometimes conflates them and he should be more selective when using the "quality" term.
I think he recognizes this, he just hasn't done much about it. http://lkml.org/lkml/2008/2/22/307
Ingo, could you please just substitute conformity for quality in these sorts of posts? Perhaps you could also change the name of your code-quality script to style-conformity?
| |