lkml.org 
[lkml]   [2008]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [build fix] Re: [GIT PATCH] SCSI part 1

* Matthew Wilcox <matthew@wil.cx> wrote:

> On Wed, Jul 16, 2008 at 04:18:05PM +0200, Ingo Molnar wrote:
> > btw., about the technical aspects of the solution, i'm not sure i like
> > these big #ifdef blocks:
>
> It's partly the nature of the beast. There's already several large
> #ifdef blocks in compat_ioctl.c -- CONFIG_NET, CONFIG_VT,
> #CONFIG_SPARC, etc. I think what would help is a bit more grouping so
> #individual blocks get bigger.

yeah, that's OK - but why is scsi.h #ifdef-ed? For example we can
include blkdev.h without #ifdef CONFIG_BLOCK.

Ingo


\
 
 \ /
  Last update: 2008-07-16 16:49    [W:0.097 / U:0.344 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site