Messages in this thread | | | Date | Wed, 16 Jul 2008 17:30:33 +0300 | From | Adrian Bunk <> | Subject | Re: [PATCH linux-next] Add module.h include to stacktrace.c. |
| |
Why was this patch ignored?
The build failures now made it into Linus' tree.
Stephen already fixed the powerpc one. s390 is still broken. And I just ran into this compile error on sh...
cu Adrian
On Fri, Jul 11, 2008 at 12:39:25PM +0200, Heiko Carstens wrote: > From: Heiko Carstens <heiko.carstens@de.ibm.com> > > Fixes this: > > CC arch/s390/kernel/stacktrace.o > arch/s390/kernel/stacktrace.c:84: warning: data definition has no type or storage class > arch/s390/kernel/stacktrace.c:84: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' > arch/s390/kernel/stacktrace.c:84: warning: parameter names (without types) in function declaration > arch/s390/kernel/stacktrace.c:97: warning: data definition has no type or storage class > arch/s390/kernel/stacktrace.c:97: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' > arch/s390/kernel/stacktrace.c:97: warning: parameter names (without types) in function declaration > > caused by "stacktrace: export save_stack_trace[_tsk]" > > Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com> > --- > > Ingo, the patch which causes this came in via one of your trees. > Please merge/apply. Thanks. > > arch/avr32/kernel/stacktrace.c | 1 + > arch/mips/kernel/stacktrace.c | 1 + > arch/powerpc/kernel/stacktrace.c | 1 + > arch/s390/kernel/stacktrace.c | 1 + > arch/sh/kernel/stacktrace.c | 1 + > 5 files changed, 5 insertions(+) > > Index: linux-next/arch/s390/kernel/stacktrace.c > =================================================================== > --- linux-next.orig/arch/s390/kernel/stacktrace.c > +++ linux-next/arch/s390/kernel/stacktrace.c > @@ -10,6 +10,7 @@ > #include <linux/sched.h> > #include <linux/stacktrace.h> > #include <linux/kallsyms.h> > +#include <linux/module.h> > > static unsigned long save_context_stack(struct stack_trace *trace, > unsigned long sp, > Index: linux-next/arch/avr32/kernel/stacktrace.c > =================================================================== > --- linux-next.orig/arch/avr32/kernel/stacktrace.c > +++ linux-next/arch/avr32/kernel/stacktrace.c > @@ -10,6 +10,7 @@ > #include <linux/sched.h> > #include <linux/stacktrace.h> > #include <linux/thread_info.h> > +#include <linux/module.h> > > register unsigned long current_frame_pointer asm("r7"); > > Index: linux-next/arch/mips/kernel/stacktrace.c > =================================================================== > --- linux-next.orig/arch/mips/kernel/stacktrace.c > +++ linux-next/arch/mips/kernel/stacktrace.c > @@ -7,6 +7,7 @@ > */ > #include <linux/sched.h> > #include <linux/stacktrace.h> > +#include <linux/module.h > #include <asm/stacktrace.h> > > /* > Index: linux-next/arch/powerpc/kernel/stacktrace.c > =================================================================== > --- linux-next.orig/arch/powerpc/kernel/stacktrace.c > +++ linux-next/arch/powerpc/kernel/stacktrace.c > @@ -12,6 +12,7 @@ > > #include <linux/sched.h> > #include <linux/stacktrace.h> > +#include <linux/module.h> > #include <asm/ptrace.h> > > /* > Index: linux-next/arch/sh/kernel/stacktrace.c > =================================================================== > --- linux-next.orig/arch/sh/kernel/stacktrace.c > +++ linux-next/arch/sh/kernel/stacktrace.c > @@ -12,6 +12,7 @@ > #include <linux/sched.h> > #include <linux/stacktrace.h> > #include <linux/thread_info.h> > +#include <linux/module.h> > #include <asm/ptrace.h> > > /* > -- > To unsubscribe from this list: send the line "unsubscribe linux-next" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
| |