Messages in this thread | | | Subject | Re: [RESEND PATCH] kmemtrace: SLAB hooks. | From | Pekka Enberg <> | Date | Tue, 15 Jul 2008 10:17:18 +0300 |
| |
On Mon, 2008-07-14 at 21:37 +0300, eduard.munteanu@linux360.ro wrote: > > I'm okay with this approach but then you need to do > > s/__kmem_cache_alloc/kmem_cache_alloc_trace/ or similar. In the kernel, > > it's always the *upper* level function that doesn't have the > > underscores. > > Hmm, doesn't really make sense: > 1. This should be called kmem_cache_alloc_notrace, not *_trace. > __kmem_cache_alloc() _disables_ tracing.
kmem_cache_alloc_notrace() sounds good to me.
> 2. __kmem_cache_alloc is not really upper level now, since it's called > only in kmalloc. So it's an internal function which is not supposed to > be used by other kernel code. > > Are you sure I should do this?
Yes.
| |