Messages in this thread | | | Date | Tue, 15 Jul 2008 14:22:10 -0400 | From | Mathieu Desnoyers <> | Subject | Re: [patch 01/15] Kernel Tracepoints |
| |
* Peter Zijlstra (peterz@infradead.org) wrote: > On Tue, 2008-07-15 at 10:46 -0400, Mathieu Desnoyers wrote: > > > Talking about headers, I have noticed that placing headers with the code > > may not be as clean as I would hope. For instance, the kernel/irq-trace.h > > header, when included from kernel/irq/handle.c, has to be included with: > > > > #include "../irq-trace.h" > > > > Which is not _that_ bad, but we we want to instrument the irq handler > > found in arch/x86/kernel/cpu/mcheck/mce_intel_64.c, including > > #include "../../../../../kernel/irq-trace.h" makes me go "yeeeek!" > > > > How about creating include/trace/irq.h and friends ? > > Might as well.. anybody else got opinions? >
I'm also wondering if it's better to have :
filemap.h fs.h hugetlb.h ipc.h ipv4.h ipv6.h irq.h kernel.h memory.h net.h page.h sched.h swap.h timer.h
all in include/trace/ or to create subdirectories first, like :
include/trace/net/ include/trace/mm/ ...
or to go the other way around and re-use the existing subdirectories :
include/net/trace/ include/mm/trace/ ...
?
Mathieu
-- Mathieu Desnoyers OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
| |