Messages in this thread | | | Subject | Re: [PATCH] x86: traps and do_traps under one hood | From | David Woodhouse <> | Date | Tue, 15 Jul 2008 07:21:43 -0700 |
| |
On Tue, 2008-07-15 at 16:22 +0530, Jaswinder Singh wrote: > Declaring x86 traps under one hood. > Declaring x86 do_traps before defining them.
> arch/x86/kernel/traps_32.c | 20 --------- > arch/x86/kernel/traps_64.c | 21 ---------- > include/asm-x86/mach-default/mach_traps.h | 62 +++++++++++++++++++++++++++++
You put these back in mach-default/mach_traps.h but does that cover all possibilities? What about other machine types?
Looking at the ifdefs you introduced in that header, it seems there's more scope for unification here (although it makes sense for that to come later).
-- dwmw2
| |