lkml.org 
[lkml]   [2008]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/1] LCD backlight driver using Atmel PWM driver
From
Date
On Fri, 2008-07-11 at 12:17 -0700, Andrew Morton wrote:
> On Wed, 9 Jul 2008 15:08:06 +0200 Hans-Christian Egtvedt <hans-christian.egtvedt@atmel.com> wrote:
>
> > + if (bd->props.power != FB_BLANK_UNBLANK)
> > + intensity = 0;
> > + if (bd->props.fb_blank != FB_BLANK_UNBLANK)
> > + intensity = 0;
>
> hm, is that correct? It is strange that two different fields can validly
> be compared with the same enumeration like this.
>

I also found it a bit weird having two fields indicating the same, but
the header file has the following documentation:

/* Current FB Power mode (0: full on, 1..3: power saving
modes; 4: full off), see FB_BLANK_XXX */
int power;
/* FB Blanking active? (values as for power) */
int fb_blank;
So, AFAIK, my assumptions are correct to get proper blanking?

--
With kind regards,
Hans-Christian Egtvedt, Applications Engineer



\
 
 \ /
  Last update: 2008-07-14 09:45    [from the cache]
©2003-2011 Jasper Spaans