lkml.org 
[lkml]   [2008]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] Fix pci_subsys_init() to have a return value
Date
On Friday, July 11, 2008 2:46 am David Howells wrote:
> Fix pci_subsys_init() to return a value (0) when it has finished. All the
> functions it calls currently return 0, so returning 0 here unconditionally
> rather than gathering the results of its callees would seem reasonable.
>
> Signed-off-by: David Howells <dhowells@redhat.com>
> ---
>
> arch/x86/pci/legacy.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
>
> diff --git a/arch/x86/pci/legacy.c b/arch/x86/pci/legacy.c
> index 3c1d795..00e29c8 100644
> --- a/arch/x86/pci/legacy.c
> +++ b/arch/x86/pci/legacy.c
> @@ -63,5 +63,6 @@ int __init pci_subsys_init(void)
> pci_legacy_init();
> pcibios_irq_init();
> pcibios_init();
> + return 0;
> }
> subsys_initcall(pci_subsys_init);

Looks like Robert already pushed a patch like this via the x86 tree, but at
least it's been fixed.

Thanks,
Jesse


\
 
 \ /
  Last update: 2008-07-14 23:23    [W:0.046 / U:0.452 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site