Messages in this thread Patch in this message | | | Date | Mon, 14 Jul 2008 20:25:13 +0900 | From | KOSAKI Motohiro <> | Subject | [mmotm] init_call_single_data makes int |
| |
Patch title: full-conversion-to-early_initcall-interface-remove-old-interface-fix-fix-fix.patch Against: mmotm Jul 14 Applies after: full-conversion-to-early_initcall-interface-remove-old-interface-fix-fix.patch
Now, init_call_single_data is early init function. then, its return type should be int.
kernel/smp.c:47: warning: initialization from incompatible pointer type
Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> Signed-off-by: Hugh Dickins <hugh@veritas.com> CC: Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro> Cc: Tom Zanussi <tzanussi@gmail.com> Cc: Jens Axboe <jens.axboe@oracle.com>
--- kernel/smp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Index: b/kernel/smp.c =================================================================== --- a/kernel/smp.c +++ b/kernel/smp.c @@ -33,7 +33,7 @@ struct call_single_queue { spinlock_t lock; }; -static void __cpuinit init_call_single_data(void) +static int __cpuinit init_call_single_data(void) { int i; @@ -43,6 +43,7 @@ static void __cpuinit init_call_single_d spin_lock_init(&q->lock); INIT_LIST_HEAD(&q->list); } + return 0; } early_initcall(init_call_single_data);
| |