lkml.org 
[lkml]   [2008]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -next-20080709] fixup stop_machine use cpu mask vs ftrace

* Ingo Molnar <mingo@elte.hu> wrote:

>
> * Milton Miller <miltonm@bga.com> wrote:
>
> > Hi Rusty, Ingo.
> >
> > Rusty's patch [PATCH 3/3] stop_machine: use cpu mask rather than magic
> > numbers didn't find kernel/trace/ftrace.c in -next, causing an
> > immediate almost NULL pointer dereference in ftrace_dynamic_init.
>
> Rusty - what's going on here? Please do not change APIs like that,
> which cause code to crash. Either do a compatible API change, or
> change it over in a way that causes clear build failures, not crashes.

ah, i see it from Rusty's other reply that there's going to be another
version of this. Good :-)

Ingo


\
 
 \ /
  Last update: 2008-07-11 10:59    [W:0.046 / U:6.052 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site