Messages in this thread | | | Date | Fri, 11 Jul 2008 23:41:05 +0200 | From | Samuel Ortiz <> | Subject | Re: [patch 4/4] MFD: Change mfd platform device usage to wrapper platform_device |
| |
On Wed, Jul 09, 2008 at 10:03:14PM +0100, Russell King - ARM Linux wrote: > On Wed, Jul 09, 2008 at 03:52:08PM +0400, Dmitry wrote: > > 2008/7/9 ian <spyro@f2s.com>: > > > On Wed, 2008-07-09 at 15:15 +0400, Dmitry wrote: > > >> NAK. > > >> 0) It was discussed yesterday on the list and the decision was to go > > >> in a different way. > > > > > > It was? > > > > > > I prefer the wrapped way personally... > > > > In any case IMO it's better to call platform_device_register() rather than > > device_initialise()/platform_device_add(). > > > > Samuel? Russell? > > WTF??? That's just completely wrong - assuming the internals of how the > platform device alloc API works... > > What it's clear from my *brief* read of this thread is that the MFD > support doesn't seem to be ready for mainline yet - there's clearly issues > here that need further work. I think the main issue at the moment is that it's not passing generic platform data if we ever want to use an existing driver as a cell driver. I'd say this is more of a lack of feature rather than broken code, so please dont drop the mfd-core patch.
Cheers, Samuel.
> Given that, and where we are (there's maybe two of *my* days left until > the merge window opens) I'm *very* tempted to drop the MFD support out > of my tree for this merge window - which basically means removing > 5127/1, 5128/1 and 5129/1. > > ------------------------------------------------------------------- > List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel > FAQ: http://www.arm.linux.org.uk/mailinglists/faq.php > Etiquette: http://www.arm.linux.org.uk/mailinglists/etiquette.php
| |