lkml.org 
[lkml]   [2008]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: SL*B: drop kmem cache argument from constructor
From
Date

On Fri, 2008-07-11 at 12:22 -0700, Andrew Morton wrote:
> On Thu, 10 Jul 2008 11:44:16 -0500 Jon Tollefson <kniht@linux.vnet.ibm.com> wrote:
>
> > Alexey Dobriyan wrote:
> > > Kmem cache passed to constructor is only needed for constructors that are
> > > themselves multiplexeres. Nobody uses this "feature", nor does anybody uses
> > > passed kmem cache in non-trivial way, so pass only pointer to object.
> > >
> > > Non-trivial places are:
> > > arch/powerpc/mm/init_64.c
> > > arch/powerpc/mm/hugetlbpage.c
> > >
> > ...<snip>...
> > > --- a/arch/powerpc/mm/hugetlbpage.c
> > > +++ b/arch/powerpc/mm/hugetlbpage.c
> > > @@ -595,9 +595,9 @@ static int __init hugepage_setup_sz(char *str)
> > > }
> > > __setup("hugepagesz=", hugepage_setup_sz);
> > >
> > > -static void zero_ctor(struct kmem_cache *cache, void *addr)
> > > +static void zero_ctor(void *addr)
> > > {
> > > - memset(addr, 0, kmem_cache_size(cache));
> > > + memset(addr, 0, HUGEPTE_TABLE_SIZE);
> > >
> > This isn't going to work with the multiple huge page size support. The
> > HUGEPTE_TABLE_SIZE macro now takes a parameter with of the mmu psize
> > index to indicate the size of page.
> >
>
> hrm. I suppose we could hold our noses and use ksize(), assuming that
> we're ready to use ksize() at this stage in the object's lifetime.

ksize() on non-kmalloced objects is considered harmful. Doesn't work on SLOB.

> Better would be to just use kmem_cache_zalloc()?

I'd say so.

--
Mathematics is the supreme nostalgia of our time.



\
 
 \ /
  Last update: 2008-07-11 21:43    [W:0.060 / U:12.480 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site