lkml.org 
[lkml]   [2008]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -mm] markers: avoid call_rcu_sched if old is NULL
On Tue, 8 Jul 2008 23:02:01 -0400 Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca> wrote:

> * Masami Hiramatsu (mhiramat@redhat.com) wrote:
> > Introduce marker_entry_free_old() and check old pointer is NULL before
> > setting call_rcu_sched(), because marker_entry_remove/add_probe() can
> > return NULL.
> >
>
> Hi Masami,
>
> I doubt this is a bug per se, because kfree accepts NULL pointers (and
> kfree is the only action done on the oldptr by free_old_closure).
>
> This cleans up the code, so I think it's good to merge your patch, but I
> would definitely not classify this as a bugfix.
>
> Acked-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>

I cannot get this to apply on the rather dated tree which I have on this
rather not-on-the-internet machine. Please merge this patch locally, test,
rewrite the changelog and resend it to someone ;)



\
 
 \ /
  Last update: 2008-07-11 21:25    [W:0.044 / U:2.548 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site