Messages in this thread | | | Date | Fri, 11 Jul 2008 09:50:31 -0400 | From | Alan Cox <> | Subject | Re: [PATCH] Fix ia64 simserial.c for Ldisc revamp |
| |
On Thu, Jul 10, 2008 at 01:46:49PM -0700, Luck, Tony wrote: > This driver is "hidden" in arch/ia64 ... so it didn't get updated > by the Ldisc revamp. > > Signed-off-by: Tony Luck <tony.luck@intel.com> > > > @@ -354,8 +354,8 @@ static void rs_flush_buffer(struct tty_struct *tty) > wake_up_interruptible(&tty->write_wait); > > if ((tty->flags & (1 << TTY_DO_WRITE_WAKEUP)) && > - tty->ldisc.write_wakeup) > - (tty->ldisc.write_wakeup)(tty); > + tty->ldisc.ops->write_wakeup) > + (tty->ldisc.ops->write_wakeup)(tty);
We have a tty_wakeup method, drivers shouldn't be poking around in tty flags any more
> - if (tty->ldisc.flush_buffer) tty->ldisc.flush_buffer(tty); > + if (tty->ldisc.ops->flush_buffer) tty->ldisc.ops->flush_buffer(tty);
And we have a method for that too 8)
| |