lkml.org 
[lkml]   [2008]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH -next-20080709] fixup stop_machine use cpu mask vs ftrace
    Date
    On Friday 11 July 2008 17:46:03 Ingo Molnar wrote:
    > * Milton Miller <miltonm@bga.com> wrote:
    > > Hi Rusty, Ingo.
    > >
    > > Rusty's patch [PATCH 3/3] stop_machine: use cpu mask rather than magic
    > > numbers didn't find kernel/trace/ftrace.c in -next, causing an
    > > immediate almost NULL pointer dereference in ftrace_dynamic_init.
    >
    > Rusty - what's going on here? Please do not change APIs like that, which
    > cause code to crash. Either do a compatible API change, or change it
    > over in a way that causes clear build failures, not crashes.

    To be fair, I did. Unfortunately GCC only warns about passing an int to a
    pointer arg, and boom.

    But compatible is even better. Given the number of stop_machine_run users I
    thought it unlikely that a new one would be introduced during the change. I
    was wrong, so I'll do it the Right Way.

    Cheers,
    Rusty.


    \
     
     \ /
      Last update: 2008-07-11 14:37    [W:3.087 / U:0.452 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site