Messages in this thread | | | Date | Thu, 10 Jul 2008 15:49:46 +0200 | From | "Hans J. Koch" <> | Subject | Re: [PATCH] uio: uio_pdrv_genirq V2 |
| |
On Thu, Jul 10, 2008 at 01:06:31PM +0200, Uwe Kleine-König wrote: > Hi, > > Hans J. Koch wrote: > > > > + ret = uio_register_device(&pdev->dev, priv->uioinfo); > > > > + if (ret) { > > > > + dev_err(&pdev->dev, "unable to register uio device\n"); > > > > + goto bad1; > > > > + } > > > > + > > > > + platform_set_drvdata(pdev, priv); > > > This should probably go before uio_register_device. (Uups, this is an > > > issue for uio_pdrv, too.) > > > > Yes, because uio_register_device will enable the irq, and you might > > arrive in the handler without having your platform data in place. > How do we want to fix that? Should I sent a new version that also > includes the memory-leak fix and copyright specification? Or another > incremental patch?
Send another incremental patch for uio_pdrv, just for the records. I'll sort it out with Greg later, if he finds many small patches annoying, I can easily combine them.
Thanks, Hans
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |