lkml.org 
[lkml]   [2008]   [Jul]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] aio: avoid using queue_delayed_work in aio_kick_handler to schedule itself
Date
On Monday 30 June 2008 11:20:27 Nikanth Karthikesan wrote:
> On Friday 27 June 2008 18:41:37 Jeff Moyer wrote:
> > Nikanth Karthikesan <knikanth@suse.de> writes:
> > > Avoid using queue_delayed_work in aio_kick_handler() to run itself
> > > immediately. Instead use aio_run_all_iocbs()
> >
> > Can you give some rationale for this change? Also, how did you test it?
>
> The comment in aio_kick_handler(), "we're in a worker thread already, don't
> use queue_delayed_work" triggered me to do this. Ran multiple instances
> of Stephen Hemminger's aio cp for basic testing.
>
> I think this would make it unfair between different kioctx? May be only the
> comment should be removed?
>

Anyway we are scheduling it again with timeout of 0, so fairness shouldnt be a
problem? If yes, wouldn't this change reduce the overhead of queuing the work
again, and repeated lock/unlock.

Thanks
Nikanth Karthikesan


\
 
 \ /
  Last update: 2008-07-01 10:51    [W:0.073 / U:1.716 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site