Messages in this thread | | | From | OGAWA Hirofumi <> | Subject | Re: [PATCH 2/7] fat: Fix VFAT_IOCTL_READDIR_xxx and cleanup for userland | Date | Tue, 01 Jul 2008 17:33:36 +0900 |
| |
Christoph Hellwig <hch@infradead.org> writes:
> On Tue, Jul 01, 2008 at 11:57:03AM +0900, OGAWA Hirofumi wrote: >> >> "struct dirent" is a kernel type here, but is a **different type** in >> userspace! This means both the structure and the IOCTL number is wrong! >> >> So, this adds new "struct __fat_dirent" to generate correct IOCTL >> number. And kernel stuff moves to under __KERNEL__. > > Given that the current version can't actually work without defininig > it's own dirent and thus ioctl number symbolic name I wonder if these > ioctls are used at all? They must have been completely untested for > a while, and I suspect we'd be better off just removing them.
I'm not sure whether all users doesn't use. (If user uses correct dirent like I did to test in past, it generates correct number.)
Anyway, why is it better off? I think, if users which copied, this patch shouldn't have any impact, and other users can use fixed version? -- OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
| |