Messages in this thread | | | Date | Tue, 1 Jul 2008 16:34:35 +0900 | From | "MinChan Kim" <> | Subject | Re: [PATCH -mm] split_lru: fix pagevec_move_tail() doesn't treat unevictable page |
| |
On Tue, Jul 1, 2008 at 4:01 PM, KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote: > even under writebacking, page can move to unevictable list. > so shouldn't pagevec_move_tail() check unevictable? > Hi, Kosaki-san.
I can't understand this race situation. How the page can move to unevictable list while it is under writeback?
Could you explain for me ? :)
> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> > > --- > mm/swap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: b/mm/swap.c > =================================================================== > --- a/mm/swap.c > +++ b/mm/swap.c > @@ -116,7 +116,7 @@ static void pagevec_move_tail(struct pag > zone = pagezone; > spin_lock(&zone->lru_lock); > } > - if (PageLRU(page) && !PageActive(page)) { > + if (PageLRU(page) && !PageActive(page) && !PageUnevictable(page)) { > int lru = page_is_file_cache(page); > list_move_tail(&page->lru, &zone->lru[lru].list); > pgmoved++; > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ >
-- Kinds regards, MinChan Kim
| |