Messages in this thread | | | Date | Tue, 1 Jul 2008 12:13:43 -0700 | From | Greg KH <> | Subject | Re: [PATCH] USB: fix interrupt disabling for HCDs with shared interrupt handlers |
| |
On Tue, Jul 01, 2008 at 02:59:38PM -0400, Alan Stern wrote: > On Tue, 1 Jul 2008, Greg KH wrote: > > > Hm, isn't this also an issue in 2.6.25 as well? I've had a few very > > strange reports of USB just locking up in 2.6.25, could this also be the > > cause there? > > It could go back a lot farther than that. I don't think our interrupt > setup has been changed significantly for a long time, with one > exception: We added the IRQF_DISABLED flag fairly recently. But of > course, we now know that it doesn't do what we expected. > > It's surprising that more people haven't experienced this problem and > reported it.
Ok, I'll queue it up for -stable as well.
> > Alan and Dave, do you both ack this thing? I know you've been involved > > in creating it, just want to get the formal approval :) > > Acked-by: Alan Stern <stern@rowland.harvard.edu> > > There still are a few places where spaces were used instead of tabs for > indenting. Aside from that it looks fine.
Thanks, I'll clean that up by hand, not a big deal :)
greg k-h
| |