Messages in this thread | | | Subject | Re: [RFC PATCH] - scripts/CodingStyle_sizeof - standardize sizeof and [PATCH] drivers/infiniband - standardize sizeof(foo) | From | Joe Perches <> | Date | Tue, 01 Jul 2008 10:37:44 -0700 |
| |
On Tue, 2008-07-01 at 10:57 -0700, Roland Dreier wrote: > This seems like needless churn to me. I personally prefer to see > "sizeof foo" instead of "sizeof(foo)", since sizeof is not a function, > and in any case I don't see much value in making this type of trivial > change.
No value but standardization and ease of grep.
fyi: drivers/infiniband uses 3 different styles for sizeof. Your preferred style is not the most frequently used.
$ grep -Pr --include=*.[ch] "\bsizeof\(" drivers/infiniband | wc -l 785 $ grep -Pr --include=*.[ch] "\bsizeof\s+\(" drivers/infiniband | wc -l 226 $ grep -Pr --include=*.[ch] "\bsizeof\s+[^\(]" drivers/infiniband | wc -l 523
cheers, Joe
| |