Messages in this thread | | | Date | Tue, 10 Jun 2008 11:51:24 +0900 | From | Tejun Heo <> | Subject | Re: [RFC] expand link_power_management_policy definition |
| |
Jeff Garzik wrote: > Kristen Carlson Accardi wrote: >> I think I mentioned on the list a couple weeks ago that I favor just >> expanding the definition of link power management to include >> the notion of simply powering the entire port off rather >> than adding new knobs to sysfs. I wrote this completely untested and >> very incomplete patch to give you a better idea of what I am proposing. >> This patch adds a new valid value of "power_off" for the existing >> link_power_management_policy sysfs entry: > > Looks fine to me... that would work nicely. > > I think your patch is missing code to handle the transition from > power_off to <something else>, though, right? > > I'm quite happy with this approach.
I agree this is the right place to implement the control.
Thanks.
-- tejun
| |