lkml.org 
[lkml]   [2008]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [2.6.26 patch] fat_valid_media() isn't for userspace
    On Mon, Jun 09, 2008 at 01:12:37PM +0900, OGAWA Hirofumi wrote:
    > "H. Peter Anvin" <hpa@kernel.org> writes:
    >
    > > The other thing about this header that needs to be fixed is the
    > > definition of the following ioctls:
    > >
    > > #define VFAT_IOCTL_READDIR_BOTH _IOR('r', 1, struct dirent [2])
    > > #define VFAT_IOCTL_READDIR_SHORT _IOR('r', 2, struct dirent [2])
    > >
    > > "struct dirent" is a kernel type here, but is a **different type** in
    > > userspace! This means both the structure and the IOCTL number is wrong!
    > >
    > > We need to make this either __kernel_dirent_t[*] or something like
    > > struct __msdos_fs_dirent.
    >
    > I see. "struct dirent" in linux/dirent.h has very few users in kernel,
    > and probably userland doesn't use it, so it seems it should be renamed.
    >
    > Well, the patch is like this (sorry, other cleanup is in this patch)?
    >...

    I wanted to ask whether it could have had any users at all, but at least
    Wine contains a workaround for our bug...

    > Thanks.
    >
    > > -hpa
    >...
    > OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
    >...

    cu
    Adrian

    --

    "Is there not promise of rain?" Ling Tan asked suddenly out
    of the darkness. There had been need of rain for many days.
    "Only a promise," Lao Er said.
    Pearl S. Buck - Dragon Seed



    \
     
     \ /
      Last update: 2008-06-09 10:09    [W:0.038 / U:93.020 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site