lkml.org 
[lkml]   [2008]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] x86: coding style fixes to arch/x86/kernel/io_apic_32.c
    On Mon, Jun 9, 2008 at 9:02 PM, Ingo Molnar <mingo@elte.hu> wrote:
    >
    > * Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com> wrote:
    >
    >> Before:
    >> total: 91 errors, 73 warnings, 2850 lines checked
    >>
    >> After:
    >> total: 1 errors, 47 warnings, 2848 lines checked
    >
    > applied, thanks. A small detail:

    Thank you. Did you manage to look/apply the other two patches as well?
    http://lkml.org/lkml/2008/6/7/64
    http://lkml.org/lkml/2008/6/7/62

    The latter might suffer for the same problem you fixed with the below patch.

    >> +++ b/arch/x86/kernel/io_apic_32.c
    >> @@ -37,12 +37,12 @@
    >> #include <linux/kthread.h>
    >> #include <linux/jiffies.h> /* time_after() */
    >>
    >> -#include <asm/io.h>
    >> -#include <asm/smp.h>
    >> +#include <linux/io.h>
    >> +#include <linux/smp.h>
    >
    > i suspect checkpatch suggested that asm/smp.h -> linux/smp.h change, but
    > there was a subtle detail here - asm/smp.h has dual role on x86, it also
    > carries a fair number of low level details about APIC/SMP details -
    > which matters on UP IOAPIC.

    You are right.
    Sorry for not catching that.

    BTW, I'm a bit lost in all the branches you are managing in the tip tree :-)
    Which one should I look at to notice when the patches are applied?

    Thanks.

    Regards,
    --
    Paolo
    http://paolo.ciarrocchi.googlepages.com/


    \
     
     \ /
      Last update: 2008-06-09 23:03    [W:0.030 / U:63.016 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site