lkml.org 
[lkml]   [2008]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] vmallocinfo: Add NUMA informations
    On Tue, 3 Jun 2008, Andrew Morton wrote:

    > > + if (NUMA_BUILD) {
    > > + unsigned int *counters, nr;
    > > +
    > > + counters = kzalloc(nr_node_ids * sizeof(unsigned int),
    >
    > This is kcalloc(). If you like that sorts of thing - I think kcalloc()
    > is pretty pointless personally.

    Same here. I think its generally ignored. I tried to remove it at some
    point in the past. If we want kcalloc then we also need kczalloc. It would
    be best to keep the interface simple.

    > Do we actually need dynamic allocation here? There's a small,
    > constant, known-at-compile-time upper bound to the number of nodes IDs?

    The number of node ids may reach 1024.


    \
     
     \ /
      Last update: 2008-06-09 16:19    [W:0.028 / U:31.312 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site