Messages in this thread | | | Date | Mon, 9 Jun 2008 23:07:52 +1000 | From | Stephen Rothwell <> | Subject | Re: [PATCH 2/4] drivers/macintosh/smu.c: add missing of_node_put |
| |
On Mon, 9 Jun 2008 14:20:42 +0200 (CEST) Julia Lawall <julia@diku.dk> wrote: > > From: Julia Lawall <julia@diku.dk> > > of_node_put is needed before discarding a value received from > of_find_node_by_type, eg in error handling code. > > The semantic patch that makes the change is as follows: > (http://www.emn.fr/x-info/coccinelle/) > > // <smpl> > @@ > struct device_node *n; > struct device_node *n1; > struct device_node *n2; > statement S; > identifier f1,f2; > expression E1,E2; > constant C; > @@ > > n = of_find_node_by_type(...) > ... > if (!n) S > ... when != of_node_put(n) > when != n1 = f1(n,...) > when != E1 = n > when any > when strict > ( > + of_node_put(n); > return -C; > | > of_node_put(n); > | > n2 = f2(n,...) > | > E2 = n > | > return ...; > ) > // </smpl> > > Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Stephen Rothwell <sfr@canb.auug.org.au>
However, the error handling in that routine (smu_init) needs much more work.
-- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ [unhandled content-type:application/pgp-signature] | |