lkml.org 
[lkml]   [2008]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 3/3] Use reserve_bootmem_generic() to reserve crashkernel memory on x86_64
    This patch uses reserve_bootmem_generic() instead of reserve_bootmem()
    to reserve the crashkernel memory on x86_64. That's necessary for NUMA
    machines, see 00212fef814612245ed0261cbac8426d0c9a31a5:

    [PATCH] Fix kdump Crash Kernel boot memory reservation for NUMA machines

    This patch will fix a boot memory reservation bug that trashes memory on
    the ES7000 when loading the kdump crash kernel.

    The code in arch/x86_64/kernel/setup.c to reserve boot memory for the crash
    kernel uses the non-numa aware "reserve_bootmem" function instead of the
    NUMA aware "reserve_bootmem_generic". I checked to make sure that no other
    function was using "reserve_bootmem" and found none, except the ones that
    had NUMA ifdef'ed out.

    I have tested this patch only on an ES7000 with NUMA on and off (numa=off)
    in a single (non-NUMA) and multi-cell (NUMA) configurations.

    Signed-off-by: Amul Shah <amul.shah@unisys.com>
    Looks-good-to: Vivek Goyal <vgoyal@in.ibm.com>
    Cc: Andi Kleen <ak@muc.de>
    Signed-off-by: Andrew Morton <akpm@osdl.org>
    Signed-off-by: Linus Torvalds <torvalds@osdl.org>

    The switch-back to reserve_bootmem() was accidentally introduced in
    5c3391f9f749023a49c64d607da4fb49263690eb when adding the BOOTMEM_EXCLUSIVE
    parameter.


    Signed-off-by: Bernhard Walle <bwalle@suse.de>

    ---
    arch/x86/kernel/setup_64.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/arch/x86/kernel/setup_64.c
    +++ b/arch/x86/kernel/setup_64.c
    @@ -243,7 +243,7 @@ static void __init reserve_crashkernel(v
    return;
    }

    - if (reserve_bootmem(crash_base, crash_size,
    + if (reserve_bootmem_generic(crash_base, crash_size,
    BOOTMEM_EXCLUSIVE) < 0) {
    printk(KERN_INFO "crashkernel reservation failed - "
    "memory is in use\n");


    \
     
     \ /
      Last update: 2008-06-08 15:49    [W:0.021 / U:62.928 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site