Messages in this thread | | | Date | Sun, 08 Jun 2008 18:14:01 -0700 | From | "H. Peter Anvin" <> | Subject | Re: [2.6.26 patch] fat_valid_media() isn't for userspace |
| |
OGAWA Hirofumi wrote: > > Yes. This is new one, so it shouldn't have any users of that. > Looks more better. Thanks. >
The other thing about this header that needs to be fixed is the definition of the following ioctls:
#define VFAT_IOCTL_READDIR_BOTH _IOR('r', 1, struct dirent [2]) #define VFAT_IOCTL_READDIR_SHORT _IOR('r', 2, struct dirent [2])
"struct dirent" is a kernel type here, but is a **different type** in userspace! This means both the structure and the IOCTL number is wrong!
We need to make this either __kernel_dirent_t[*] or something like struct __msdos_fs_dirent.
-hpa
[*] Yes, typedefs suck, but unfortunately C doesn't allow aliases in the structure tag namespace.
| |