Messages in this thread | | | Date | Sat, 07 Jun 2008 16:48:11 +0200 | From | Manfred Spraul <> | Subject | Re: [PATCH 1/4] ipc/sem.c: convert undo structures to struct list_head |
| |
Nadia Derbey wrote: > Manfred Spraul wrote: >> The undo structures contain two linked lists, the >> attached patch replaces them with generic struct list_head lists. > > If I'm not wrong the undo list is a singly-linked list. > So here we are moving from a set of 4 pointers to a set of 8 pointers. > It's true that this makes the code much much more readable and clear, > but I was wondering if it's worth? > IMHO yes: Everything is allocated on demand and memory is not that expensive.
With regard to the asserts: I'm a big fan of asserts, I usually use them to document the locking. Perhaps assert_spin_locked() should evalute to a nop() for non-CONFIG_DEBUG builds?
-- Manfred
| |