lkml.org 
[lkml]   [2008]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: PATCH] net: b44.c fix sleeping-with-spinlock-helt during resume
Hi Arjan, Michael,

On Sun, Jun 01, 2008 at 09:01:07AM -0700, Arjan van de Ven wrote:
> On Sun, 1 Jun 2008 12:03:40 +0200
> Michael Buesch <mb@bu3sch.de> wrote:
>
> > Index: wireless-testing/drivers/ssb/driver_pcicore.c
> > ===================================================================
> > --- wireless-testing.orig/drivers/ssb/driver_pcicore.c
> > 2008-04-23 16:06:56.000000000 +0200 +++
> > wireless-testing/drivers/ssb/driver_pcicore.c 2008-06-01
> > 12:02:33.000000000 +0200 @@ -537,12 +537,12 @@ int
> > ssb_pcicore_dev_irqvecs_enable(struc int err = 0; u32 tmp;
> >
> > - might_sleep();
> > -
> > if (!pdev)
> > goto out;
> > bus = pdev->bus;
> >
> > + might_sleep_if(pdev->id.coreid != SSB_DEV_PCI);
> > +
> > /* Enable interrupts for this device. */
> > if (bus->host_pci &&
> > ((pdev->id.revision >= 6) || (pdev->id.coreid ==
> > SSB_DEV_PCIE))) {
> >
> >
> >
>
> fair enough.... can we get something like this into 2.6.26 still? Quite
> a few people are hitting this (even though the warning is harmless, it
> still is better to silence it)

Care to CC stable when people are already hitting the problem ?

FWIW, the fix was merged in mainline as commit
a3bafeedfff2ac5fa0a316bea4570e27900b6fcc

thanks!
willy



\
 
 \ /
  Last update: 2008-06-07 08:03    [W:0.072 / U:1.248 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site