lkml.org 
[lkml]   [2008]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 01/15] MMC: S3C24XX MMC/SD driver. From: Thomas Kleffel <>
On Sat, Jun 07, 2008 at 12:13:59PM -0700, Andrew Morton wrote:
>
> (cc's restored. Please don't remove people)

Sorry, thought I had replied to all.

> On Sat, 7 Jun 2008 13:22:27 +0100 Ben Dooks <ben@fluff.org> wrote:
>
> > > right at the top of the changelog so that the commit is correctly
> > > attributed.
> > >
> > > > Signed-off-by: Ben Dooks <ben-linux@fluff.org>
> > >
> > > Please pass these patches through chechpatch? This one alone generates
> > >
> > > total: 40 errors, 29 warnings, 1488 lines checked
> > >
> > > many of which you would have fixed had you been aware of them. That's
> > > what checkpatch is for.
> >
> > Is it ok to fit another patch after this one to fixup these problems?
>
> OK by me, as would be a new patch.
>
> Pierre would be merging this (might have already done so?) - I assume
> he'd prefer a whole new patch.

I'll have to post a new series, the changes to cleanup make the rest of
the series either fuzz, offset or just fail to apply. I'll run the new
series through a test to check that it still works.

--
Ben

Q: What's a light-year?
A: One-third less calories than a regular year.


\
 
 \ /
  Last update: 2008-06-07 21:53    [W:0.448 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site