[lkml]   [2008]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 4/8] atmel_nand: Clean up and fix probe() error path
hi Haavard,

> This fixes several bugs in the atmel_nand_probe() error path, including
> at least one memory leak.

There is an issue with the current at91_nand driver here.

The driver currently ioremap()'s the ECC controller's registers, but
on the AT91 the ECC controller is part of the System Peripherals and
so it is already mapped at startup.
I don't think it can/should be remapped twice.

The AT91 patch (on current does:
regs = platform_get_resource(pdev, IORESOURCE_MEM, 1);
host->ecc = (void __force __iomem *) (AT91_VA_BASE_SYS - AT91_BASE_SYS);
host->ecc += regs->start;
instead of the ioremap(). But this is not portable to the AVR32.

Andrew Victor

 \ /
  Last update: 2008-06-07 18:11    [W:0.078 / U:2.564 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site