Messages in this thread | | | Date | Fri, 6 Jun 2008 10:44:27 +0200 | From | Jens Axboe <> | Subject | Re: [PATCH 1/10] Add generic helpers for arch IPI function calls |
| |
On Fri, May 30 2008, Paul E. McKenney wrote: > On Thu, May 29, 2008 at 10:58:15AM +0200, Jens Axboe wrote: > > This adds kernel/smp.c which contains helpers for IPI function calls. In > > addition to supporting the existing smp_call_function() in a more efficient > > manner, it also adds a more scalable variant called smp_call_function_single() > > for calling a given function on a single CPU only. > > > > The core of this is based on the x86-64 patch from Nick Piggin, lots of > > changes since then. "Alan D. Brunelle" <Alan.Brunelle@hp.com> has > > contributed lots of fixes and suggestions as well. Also thanks to > > Paul E. McKenney <paulmck@linux.vnet.ibm.com> for reviewing RCU usage > > and getting rid of the data allocation fallback deadlock. > > Looks much improved!!! A few suggestions for header comments, and > there appears to be a leftover memory barrier that should now be > removed. With these changes:
Thanks Paul, I added the three extra comments to the kerneldoc for those functions. And you are right about write ordering memory barrier, we don't need that anymore.
-- Jens Axboe
| |