lkml.org 
[lkml]   [2008]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 09/50] ext3/4: fix uninitialized bs in ext3/4_xattr_set_handle()
    -stable review patch.  If anyone has any objections, please let us know.
    ---------------------

    From: Tiger Yang <tiger.yang@oracle.com>

    commit 7e01c8e5420b6c7f9d85d34c15d8c7a15c9fc720 upstream

    This fix the uninitialized bs when we try to replace a xattr entry in
    ibody with the new value which require more than free space.

    This situation only happens we format ext3/4 with inode size more than 128 and
    we have put xattr entries both in ibody and block. The consequences about
    this bug is we will lost the xattr block which pointed by i_file_acl with all
    xattr entires in it. We will alloc a new xattr block and put that large value
    entry in it. The old xattr block will become orphan block.

    Signed-off-by: Tiger Yang <tiger.yang@oracle.com>
    Cc: <linux-ext4@vger.kernel.org>
    Cc: Andreas Gruenbacher <agruen@suse.de>
    Acked-by: Andreas Dilger <adilger@sun.com>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Signed-off-by: Chris Wright <chrisw@sous-sol.org>

    ---
    fs/ext3/xattr.c | 5 +++++
    fs/ext4/xattr.c | 5 +++++
    2 files changed, 10 insertions(+)

    --- a/fs/ext3/xattr.c
    +++ b/fs/ext3/xattr.c
    @@ -1000,6 +1000,11 @@ ext3_xattr_set_handle(handle_t *handle,
    i.value = NULL;
    error = ext3_xattr_block_set(handle, inode, &i, &bs);
    } else if (error == -ENOSPC) {
    + if (EXT3_I(inode)->i_file_acl && !bs.s.base) {
    + error = ext3_xattr_block_find(inode, &i, &bs);
    + if (error)
    + goto cleanup;
    + }
    error = ext3_xattr_block_set(handle, inode, &i, &bs);
    if (error)
    goto cleanup;
    --- a/fs/ext4/xattr.c
    +++ b/fs/ext4/xattr.c
    @@ -1011,6 +1011,11 @@ ext4_xattr_set_handle(handle_t *handle,
    i.value = NULL;
    error = ext4_xattr_block_set(handle, inode, &i, &bs);
    } else if (error == -ENOSPC) {
    + if (EXT4_I(inode)->i_file_acl && !bs.s.base) {
    + error = ext4_xattr_block_find(inode, &i, &bs);
    + if (error)
    + goto cleanup;
    + }
    error = ext4_xattr_block_set(handle, inode, &i, &bs);
    if (error)
    goto cleanup;
    --


    \
     
     \ /
      Last update: 2008-06-07 03:29    [W:4.177 / U:0.208 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site