Messages in this thread | | | Date | Fri, 6 Jun 2008 10:24:53 -0400 | From | Dmitry Torokhov <> | Subject | Re: [lm-sensors] [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection System 3D ACPI driver -- please review! |
| |
Hi,
On Fri, Jun 06, 2008 at 12:27:10AM +0200, Pau Oliva Fora wrote: > From: Pau Oliva Fora <pau@eslack.org> > > Add support for HTC Shift UMPC G-Sensor LIS3LV02DL accelerometer. > > Signed-off-by: Pau Oliva Fora <pau@eslack.org> >
The input piece looks good, however it seens that the input is the only functionality that this driver exports so I don't see any reason to make input device registration optional. Or are you planning on adding more functions to it?
Thanks.
-- Dmitry
| |