Messages in this thread | | | Date | Thu, 5 Jun 2008 12:05:51 -0400 | From | "Thomas Tuttle" <> | Subject | Re: [PATCH 3/5] pagemap: Make pagemap_read enforce reading in multiples of 8 |
| |
On Thu, Jun 5, 2008 at 12:03 PM, Matt Mackall <mpm@selenic.com> wrote: > > On Thu, 2008-06-05 at 11:06 -0400, Thomas Tuttle wrote: >> Since kpagecount and kpageflags require reads in multiples of 8, and >> it simplifies add_to_pagemap significantly, I added the same >> requirement to /proc/pid/pagemap. > > I'm generally fine with this. Another approach that's perhaps more > friendly is when someone tries to do a 24-byte read, do a 16-byte read, > leaving the file pointer aligned. Not sure if that's completely kosher > though.
This doesn't require that they read exactly 8 bytes, just that they read some multiple of 8 bytes. (They can read 8, 16, 24, etc..., just not something like 12.)
--ttuttle
| |