Messages in this thread | | | Date | Thu, 5 Jun 2008 13:08:30 +0100 | From | Ben Hutchings <> | Subject | Re: [PATCH] cputopology: Always define CPU topology information [4th try] |
| |
Andrew Morton wrote: > On Wed, 4 Jun 2008 16:44:56 +0100 Ben Hutchings <bhutchings@solarflare.com> wrote: > > > Not all architectures and configurations define CPU topology information. > > This can result in an empty topology directory in sysfs, and requires > > in-kernel users to protect all uses with #ifdef - see > > <http://marc.info/?l=linux-netdev&m=120639033904472&w=2>. > > > > The documentation of CPU topology specifies what the defaults should be > > if only partial information is available from the hardware. So we can > > provide these defaults as a fallback. > > > > This patch: > > > > - Adds default definitions of the 4 topology macros to <linux/topology.h> > > - Changes drivers/base/topology.c to use the topology macros unconditionally > > and to cope with definitions that aren't lvalues > > - Updates documentation accordingly > > See, this is what I meant. After your patch we have: [...]
Sorry, I don't know how that escaped me. My changes to the show functions should be unnecessary - though I think that the two different implementations for lvalues and rvalues are a premature optimisation.
Ben.
-- Ben Hutchings, Senior Software Engineer, Solarflare Communications Not speaking for my employer; that's the marketing department's job.
| |