Messages in this thread | | | Date | Thu, 5 Jun 2008 19:53:50 +0900 | From | "KOSAKI Motohiro" <> | Subject | Re: [RFC][PATCH] introduce task cgroup (#task restrictioon for prevent fork bomb by cgroup) |
| |
> You are not handling task migration between groups, i.e.: > # echo $$ > /cgroup/1/tasks > # echo $$ > /cgroup/2/tasks
Oh, nice point out. Thanks!
> Maybe you need to add this in cgroup_init_subsys(): > > - need_forkexit_callback |= ss->fork || ss->exit; > + need_forkexit_callback |= ss->fork || ss->exit || ss->can_fork; > > and then we can do: > > if (need_forkexit_callback) { > for (i = 0; i < CGROUP_SUBSYS_COUNT; i++) {
good idea :) I'll fix it at next post.
| |