lkml.org 
[lkml]   [2008]   [Jun]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] cgroup: list_for_each cleanup
> > -       while (!list_empty(&release_list)) {
> > +
> > + list_for_each_entry_safe(cgrp, saved_cgrp, &release_list,
> > + release_list) {
> > char *argv[3], *envp[3];
> > int i;
> > char *pathbuf;
> > - struct cgroup *cgrp = list_entry(release_list.next,
> > - struct cgroup,
> > - release_list);
> > +
>
> I don't think that list_for_each_entry_safe() is still safe when we've
> dropped release_list_lock. saved_cgroup could end up pointing to a
> cgroup that's freed while we're forking the usermode helper.

Ah, you are right.
I'll drop this portion and resend patch.

Thanks.




\
 
 \ /
  Last update: 2008-06-04 11:23    [W:0.038 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site