Messages in this thread | | | Subject | Re: [patch -v3 16/22] acpi: use memory_read_from_buffer | From | Zhao Yakui <> | Date | Thu, 05 Jun 2008 09:21:26 +0800 |
| |
On Wed, 2008-06-04 at 20:56 +0900, Akinobu Mita wrote: > plain text document attachment > (acpi-use-memory-read-from-buffer.patch) > Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com> > Cc: Len Brown <len.brown@intel.com> > Cc: linux-acpi@vger.kernel.org > --- > drivers/acpi/system.c | 15 ++------------- > 1 file changed, 2 insertions(+), 13 deletions(-) > > Index: 2.6-git/drivers/acpi/system.c > =================================================================== > --- 2.6-git.orig/drivers/acpi/system.c > +++ 2.6-git/drivers/acpi/system.c > @@ -77,7 +77,6 @@ static ssize_t acpi_table_show(struct ko > container_of(bin_attr, struct acpi_table_attr, attr); > struct acpi_table_header *table_header = NULL; > acpi_status status; > - ssize_t ret_count = count; > > status = > acpi_get_table(table_attr->name, table_attr->instance, > @@ -85,18 +84,8 @@ static ssize_t acpi_table_show(struct ko > if (ACPI_FAILURE(status)) > return -ENODEV; > > - if (offset >= table_header->length) { > - ret_count = 0; > - goto end; > - } > - > - if (offset + ret_count > table_header->length) > - ret_count = table_header->length - offset; > - > - memcpy(buf, ((char *)table_header) + offset, ret_count); > - > - end: > - return ret_count; > + return memory_read_from_buffer(buf, count, &offset, > + table_header, table_header->length); > } it seems that there is no definition of memory_read_from_buffer. Where is the function of memory_read_from_buffer defined? Is there a bug about the current function of acpi_table_show? Thanks. > > static void acpi_table_attr_init(struct acpi_table_attr *table_attr, >
| |