Messages in this thread | | | Date | Thu, 5 Jun 2008 09:04:25 +0900 | From | KAMEZAWA Hiroyuki <> | Subject | Re: [RFC][PATCH 2/2] memcg: hardwall hierarhcy for memcg |
| |
On Wed, 4 Jun 2008 21:32:35 +0900 Daisuke Nishimura <d-nishimura@mtf.biglobe.ne.jp> wrote:
> Hi. > > > @@ -848,6 +937,8 @@ static int mem_cgroup_force_empty(struct > > if (mem_cgroup_subsys.disabled) > > return 0; > > > > + memcg_shrink_all(mem); > > + > > css_get(&mem->css); > > /* > > * page reclaim code (kswapd etc..) will move pages between > > Shouldn't it be called after verifying there remains no task > in this group? > > If called via mem_cgroup_pre_destroy, it has been verified > that there remains no task already, but if called via > mem_force_empty_wrte, there may remain some tasks and > this means many and many pages are swaped out, doesn't it? > you're right. I misunderstood where the number of children is checked.
Thanks, -Kame
> > Thanks, > Daisuke Nishimura. >
| |