lkml.org 
[lkml]   [2008]   [Jun]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] x86: e820 max_arch_pfn typo fix for 64 bit
    Yinghai Lu wrote:
    > should use right shift
    >
    > Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>
    >
    > Index: linux-2.6/arch/x86/kernel/e820.c
    > ===================================================================
    > --- linux-2.6.orig/arch/x86/kernel/e820.c
    > +++ linux-2.6/arch/x86/kernel/e820.c
    > @@ -771,7 +771,7 @@ u64 __init early_reserve_e820(u64 startt
    > # define MAX_ARCH_PFN (1ULL<<(32-PAGE_SHIFT))
    > # endif
    > #else /* CONFIG_X86_32 */
    > -# define MAX_ARCH_PFN MAXMEM<<PAGE_SHIFT
    > +# define MAX_ARCH_PFN MAXMEM>>PAGE_SHIFT
    > #endif
    >

    Should also use parens (operator inside a macro).

    -hpa


    \
     
     \ /
      Last update: 2008-06-05 00:51    [W:0.022 / U:0.256 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site