Messages in this thread | | | Date | Tue, 3 Jun 2008 22:38:05 -0700 | From | Greg KH <> | Subject | Re: [PATCH] Firmware loader driver for USB Apple iSight camera |
| |
On Mon, Jun 02, 2008 at 09:21:03PM +0200, Ingo Molnar wrote: > > * Matthew Garrett <mjg59@srcf.ucam.org> wrote: > > > Uninitialised Apple iSight drivers present with a distinctive USB ID. > > Once firmware has been uploaded, they disconnect and reconnect with a > > new ID. At this point they can be driven by the uvcvideo driver. As > > this is unique to the Apple cameras and not functionality shared by > > any other UVC devices, it makes sense to provide the firmware loading > > functionality in a separate driver. This driver will read an isight.fw > > file extracted from the Apple driver using the tools at > > http://bersace03.free.fr/ift/ and upload it to the camera. It will > > also handle the case where the device loses its firmware during > > hibernation and must have it reloaded. > > this caused a build failure - find the fix below. (fix can also be > pulled/cherry-picked from -tip's tip/out-of-tree topic branch) > > Ingo > > --------------------> > commit 1f910d33b2084d03267db20359472891f95b45b4 > Author: Ingo Molnar <mingo@elte.hu> > Date: Mon Jun 2 21:07:27 2008 +0200 > > USB: fix build bug in USB_ISIGHTFW > > -tip tree testing found this build bug: > > drivers/built-in.o: In function `isight_firmware_load': > isight_firmware.c:(.text+0x1ade08): undefined reference to `request_firmware' > isight_firmware.c:(.text+0x1adf9c): undefined reference to `release_firmware' > > select FW_LOADER in USB_ISIGHTFW.
Thanks, I'll add this to my queue.
greg k-h
| |