Messages in this thread | | | Date | Wed, 4 Jun 2008 22:08:58 +0400 | From | Oleg Nesterov <> | Subject | Re: [PATCH 2/2] __down_common: use signal_pending_state() |
| |
On 06/04, Matthew Wilcox wrote: > > On Wed, Jun 04, 2008 at 09:09:06PM +0400, Oleg Nesterov wrote: > > Cleanup. __down_common() can use the new signal_pending_state() helper. > > This is a bad optimisation. __down_common gets inlined and the constant > 'state' versions are optimised away for the versions which don't apply. > > NAK this patch.
OK.
But this was not optimisation, just code re-use.
Actually, I don't understand why __down_common/__mutex_lock_common are inlines, perhaps it is better to shrink .text instead.
For example, "size kernel/mutex.o" reports
2715 0 12 2727 aa7 kernel/mutex.o
with __mutex_lock_common() uninlined, we have
1565 0 12 1577 629 kernel/mutex.o
the difference is more than K.
Oleg.
| |