lkml.org 
[lkml]   [2008]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 1/7] fat: Fix parse_options()
    From
    Date

    Current parse_options() exits too early. We need to run the code of
    bottom in this function even if users doesn't specify options.

    Signed-off-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
    ---

    fs/fat/inode.c | 7 +++++--
    1 file changed, 5 insertions(+), 2 deletions(-)

    diff -puN fs/fat/inode.c~fat_default_opt-fix fs/fat/inode.c
    --- linux-2.6/fs/fat/inode.c~fat_default_opt-fix 2008-06-08 23:05:53.000000000 +0900
    +++ linux-2.6-hirofumi/fs/fat/inode.c 2008-06-08 23:05:53.000000000 +0900
    @@ -950,7 +950,7 @@ static int parse_options(char *options,
    *debug = 0;

    if (!options)
    - return 0;
    + goto out;

    while ((p = strsep(&options, ",")) != NULL) {
    int token;
    @@ -1104,10 +1104,13 @@ static int parse_options(char *options,
    return -EINVAL;
    }
    }
    +
    +out:
    /* UTF-8 doesn't provide FAT semantics */
    if (!strcmp(opts->iocharset, "utf8")) {
    printk(KERN_ERR "FAT: utf8 is not a recommended IO charset"
    - " for FAT filesystems, filesystem will be case sensitive!\n");
    + " for FAT filesystems, filesystem will be "
    + "case sensitive!\n");
    }

    /* If user doesn't specify allow_utime, it's initialized from dmask. */
    _

    \
     
     \ /
      Last update: 2008-07-01 04:59    [W:0.018 / U:30.884 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site