lkml.org 
[lkml]   [2008]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 17/39] clobber rbx in putuser_64.S
Andi Kleen wrote:
>> But for this case, I think we can come up with a macro that selects the
>> appropriate register for each of them. Should be easy to do now that the
>> code is merged.
>
> Note that each get_user() backend is ~10 lines or so. If you add
> that many macros you might end up with more code than if you
> just keep them separate.

I agree I might. But I honestly don't think this is the case here.

Does anyone else have a word on this ?

> While I admit I am also partly to blame for some asm macro
> mess, e.g. in entry.S, I relented and would now advocate
> to minimize macro use in assembler. It simply makes it much
> harder to understand and to change.
>
> -Andi
>



\
 
 \ /
  Last update: 2008-07-01 04:49    [W:0.149 / U:0.872 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site