Messages in this thread | | | Subject | Re: [PATCH 5/5] MMC: cleanup endianity conversions | From | Marcel Holtmann <> | Date | Tue, 01 Jul 2008 03:51:04 +0200 |
| |
Hi Tomas,
> static int mmc_blk_issue_rq(struct mmc_queue *mq, struct request *req) > diff --git a/drivers/mmc/core/mmc_ops.c b/drivers/mmc/core/mmc_ops.c > index e6703e5..3ad340c 100644 > --- a/drivers/mmc/core/mmc_ops.c > +++ b/drivers/mmc/core/mmc_ops.c > @@ -271,17 +271,17 @@ mmc_send_cxd_data(struct mmc_card *card, struct mmc_host *host, > int mmc_send_csd(struct mmc_card *card, u32 *csd) > { > int ret, i; > - > + __be32 csd_buf[4]; > if (!mmc_host_is_spi(card->host)) > return mmc_send_cxd_native(card->host, card->rca << 16, > csd, MMC_SEND_CSD);
what is up with this empty line removal. I would keep the empty line after the variable declaration.
> for (i = 0;i < 4;i++) > - csd[i] = be32_to_cpu(csd[i]); > + csd[i] = be32_to_cpu(csd_buf[i]);
While you are at it. Add the missing whitespace in the for statement :)
Otherwise, looks good to me.
Regards
Marcel
| |